PuppiMET with PUPPIv15 and UL17 PUID #31927

alefisico · 2020-10-23T17:00:39Z

PR description:

This PR includes the PuppiMET collection with the new PUPPIv15 as mentioned in this PR review for nanoAOD.
Additionally updates the training for PUID to UL17.

PR validation:

This PR succesfully passed the usual runTheMatrix.py -l limited -i all --ibeos.

Once this PR is merged, we need a backport to 10_6_X for nanoAODv8.

cmsbuild · 2020-10-23T17:01:03Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-23T17:09:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31927/19362

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): PPS nanoAOD #31531

cmsbuild · 2020-10-23T17:09:22Z

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatUtils

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @swertz, @riga, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-23T18:20:27Z

@cmsbuild please test

cmsbuild · 2020-10-23T18:20:53Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10259/console Started: 2020/10/23 20:22

cmsbuild · 2020-10-23T19:45:30Z

+1
Tested at: 3890df1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d6a1d/10259/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-23T19:45:32Z

Comparison job queued.

cmsbuild · 2020-10-23T20:59:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d6a1d/10259/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544110
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544087
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-10-26T10:11:22Z

+1

This PR only affects nanoAOD productions, and the tests only show differences in the nanoAOD outputs
The only real change (besides the removal of empy spaces) in the reco related code is in this fix of a misspelled paramenter name

cmsbuild · 2020-11-10T10:24:49Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 136.8522,1325.81,1325.61
CMSSW_11_2_X_2020-11-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10609/console Started: 2020/11/10 11:27

cmsbuild · 2020-11-10T12:02:26Z

+1
Tested at: ff0d9b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d6a1d/10609/summary.html
CMSSW: CMSSW_11_2_X_2020-11-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-10T12:02:28Z

Comparison job queued.

cmsbuild · 2020-11-10T13:53:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d6a1d/10609/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6a1d/1325.61_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6a1d/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7d6a1d/136.8522_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

mariadalfonso · 2020-11-10T18:25:43Z

+xpog

changes for:

puppiMET to accommodate the V15 tune for mini-priory the remini;
PUjetID for 2017UL

perrotta · 2020-11-10T18:54:22Z

+1

Already signed in PuppiMET with PUPPIv15 and UL17 PUID #31927 (comment), no relevant changes for reco since then
This PR only affects nanoAOD productions
The only real change (besides the removal of empy spaces) in the reco related code is in this fix of a misspelled paramenter name

santocch · 2020-11-11T19:28:13Z

+1

cmsbuild · 2020-11-11T19:28:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-11-11T20:16:57Z

+1

* adding PuppiMET with PuppiV15 and latest PUID * adding srcWeights * fix rawPuppiMET * fix rawpuppiMET * fix rawpuppimet * adding puppiForMet * fixing fatjet jetiD * adding modifiers * fixing pfCandCollection * adding 106Xv1 modifier * adding modifiers in puppiForMET * fixing modifiers for puppiForMET * style changes * style changes

alefisico added 3 commits October 23, 2020 10:38

adding PUPPIv15 to PUPPIMET

594115f

incluing UL17 PUID

e813a69

adding PuppiMET with PUPPIV15 and UL17 PUID

3890df1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 23, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Oct 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 23, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 23, 2020

cmsbuild removed the reconstruction-pending label Oct 26, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2020

alefisico mentioned this pull request Nov 10, 2020

Backport #31927 (PuppiMET with PUPPIv15 and UL17 PUID) #32076

Merged

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

cmsbuild added xpog-approved and removed xpog-pending labels Nov 10, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 10, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Nov 11, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 11, 2020

cmsbuild merged commit 7c9d085 into cms-sw:master Nov 11, 2020

mariadalfonso mentioned this pull request Nov 17, 2020

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

lathomas mentioned this pull request Nov 30, 2020

PUPPI v15 bug/crash fix for NANOAOD #32328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PuppiMET with PUPPIv15 and UL17 PUID #31927

PuppiMET with PUPPIv15 and UL17 PUID #31927

alefisico commented Oct 23, 2020 •

edited

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

slava77 commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 •

edited

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

perrotta commented Oct 26, 2020

cmsbuild commented Nov 10, 2020 •

edited

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020

perrotta commented Nov 10, 2020

santocch commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 11, 2020

PuppiMET with PUPPIv15 and UL17 PUID #31927

PuppiMET with PUPPIv15 and UL17 PUID #31927

Conversation

alefisico commented Oct 23, 2020 • edited

PR description:

PR validation:

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

slava77 commented Oct 23, 2020

cmsbuild commented Oct 23, 2020 • edited

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

cmsbuild commented Oct 23, 2020

perrotta commented Oct 26, 2020

cmsbuild commented Nov 10, 2020 • edited

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

mariadalfonso commented Nov 10, 2020

perrotta commented Nov 10, 2020

santocch commented Nov 11, 2020

cmsbuild commented Nov 11, 2020

silviodonato commented Nov 11, 2020

alefisico commented Oct 23, 2020 •

edited

cmsbuild commented Oct 23, 2020 •

edited

cmsbuild commented Nov 10, 2020 •

edited