New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex28 Add a new cff for simulation - useful for dd4hep #31929
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31929/19363
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 0632416 CMSSW: CMSSW_11_2_X_2020-10-23-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test test2021Geometry had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cmsbuild Please test |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31929/19369
|
The tests are being triggered in jenkins.
|
Pull request #31929 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
+1 |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
urgent |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add a new cff for simulation - useful for dd4hep
PR validation:
Tested using the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special