Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed file based destinations from MessageLogger_cfi #31930

Merged
merged 1 commit into from Oct 29, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The destinations were rarely used. Where they were used were updated to explicitly declare the destinations.

PR validation:

Each file was loaded into python to guarantee that it parsed correctly. All unit tests for the packages were run and succeeded.

The destinations were rarely used. Where they were used were updated
to explicitly declare the destinations.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31930/19366

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibTracker/SiStripDCS
DPGAnalysis/SiStripTools
EventFilter/GEMRawToDigi
EventFilter/L1GlobalTriggerRawToDigi
EventFilter/L1TRawToDigi
FWCore/MessageService
L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
RecoMTD/DetLayers

@perrotta, @smuzaffar, @benkrikler, @Dr15Jones, @makortel, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @yuanchao, @kpedro88, @tlampen, @jpata, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@echabert, @fabiocos, @jshlee, @makortel, @mtosi, @pieterdavid, @robervalwalsh, @JanFSchulte, @tocheng, @gbenelli, @Martin-Grunewald, @wddgit, @watson-ij, @thomreis, @jandrea, @mmusich, @threus, @ebrondol, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 23, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: df352ae
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-830f26/10264/summary.html
CMSSW: CMSSW_11_2_X_2020-10-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-830f26/10264/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544110
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544072
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@slava77
Copy link
Contributor

slava77 commented Oct 26, 2020

+1

for #31930 df352ae

  • technical; affects only a couple of reco files in /test subdirectories

@kpedro88
Copy link
Contributor

+upgrade

@santocch
Copy link

+1

@makortel
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor Author

@cms-sw/alca-l2 @cms-sw/l1-l2 ping

@christopheralanwest
Copy link
Contributor

+alca

@Dr15Jones
Copy link
Contributor Author

@cms-sw/l1-l2 ping

@silviodonato
Copy link
Contributor

merge
@cms-sw/l1-l2 please let us know if you have any comments

@cmsbuild cmsbuild merged commit 1691bb6 into cms-sw:master Oct 29, 2020
@Dr15Jones Dr15Jones deleted the removeDestinations branch October 30, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants