Add plots for displaced muon quantities to uGMT DQM #31951
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31951/19408
|
|
A new Pull Request was created by @dinyar (Dinyar Rabady) for master. It involves the following packages: DQM/L1TMonitor @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
attn @rekovic |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@dinyar just for my understanding, the new plots should monitor Run3 smaples, but they seem to be added on almost any sample, even Run1 ones |
|
Hi @jfernan2, Yes, that's true. Is there a way to avoid them being generated for older samples? We need them for the run-3 online DQM and I'd say also relvals, but otherwise not. Cheers, |
|
You would need to create a new L1T DQM module with just the Run3 plots and then enable in DQMOffline config file like (e.g.) GEM is doing: |
|
Pull request #31951 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@dinyar can you please make a last check that all the changes inrtroduced are what you expect? |
|
Hi @jfernan2, I had a look and things look as expected now. (Some mismatches are seen in the Run-3 plots, but these can be explained by the fact that the BMTF packer hasn't been updated to work for the Run-3 data format yet.) One thing I noticed is that the first time I entered some of the folders I got and icon with three exclamation marks instead of a plot. When I went into the folder above and re-entered the expected plot was there. I assume this was some glitch in the machinery and not in my code, but wanted to mention it for completeness. Cheers, |
Yes, this is a temporary glitch from DQM GUI, new GUI in development is indeed fixing that behaviour. I proceed to approve the PR given your green light. Please do not forget to create a backport in 11_1_X to have these changes in the next MWGR |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
PR description:
In Run-3 displaced muon data are received from BMTF and forwarded to the uGT. This PR adds plots for these quantities to the uGMT DQM.
PR validation:
Ran the DQM on lxplus and verified that the new plots showed up. Checked that the old plots are still there and populated.