Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor revisions to Run 3 simulation geometry #32010

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates the DB payloads for the Run 3 simulation geometry. Details of the changes can be found in the HyperNews thread.

The GT diffs are identical for all six scenarios:

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_design_v10/112X_mcRun3_2021_design_v11

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_v10/112X_mcRun3_2021_realistic_v11

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021cosmics_realistic_deco_v10/112X_mcRun3_2021cosmics_realistic_deco_v11

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2021_realistic_HI_v12/112X_mcRun3_2021_realistic_HI_v13

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2023_realistic_v10/112X_mcRun3_2023_realistic_v11

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun3_2024_realistic_v10/112X_mcRun3_2024_realistic_v11

PR validation:

Please see the AlCa HyperNews thread for details. In addition, a technical test was performed:

runTheMatrix.py -l limited,12024.0,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is anticipated.

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 12024.0,7.23,159.0,12834.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32010/19538

  • This PR adds an extra 12KB to repository

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

+1
Tested at: eb3905c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bd2f7/10458/summary.html
CMSSW: CMSSW_11_2_X_2020-11-02-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bd2f7/10458/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9bd2f7/12024.0_TTbar_13+2021Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9bd2f7/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECOMB+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9bd2f7/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5897 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 144646
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2399424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 3, 2020

The comparison differences are what is expected when comparing two independently generated MC samples of 10 events each. There are no obvious problems, and the differences are just statistical fluctuations from a very small sample.
I think this PR can be merged.
+1

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 4, 2020

+1

@cmsbuild cmsbuild merged commit 5bf34d3 into cms-sw:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants