Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106X backport: jetNDauChargedMVASel for nanoAOD electrons & muons for topMVA inputs #32024

Merged
merged 1 commit into from Nov 5, 2020

Conversation

schoef
Copy link
Contributor

@schoef schoef commented Nov 4, 2020

This is just the backport of [#31944 ] to 106X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

A new Pull Request was created by @schoef for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+1
Tested at: a7f7a74
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3541e0/10501/summary.html
CMSSW: CMSSW_10_6_X_2020-11-04-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3541e0/10501/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 170 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214664
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214329
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.154 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 1.154 KiB Physics/NanoAODDQM
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor

+xpog
changes inline with master

@santocch
Copy link

santocch commented Nov 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

backport of #31944

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f65c991 into cms-sw:CMSSW_10_6_X Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants