Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving METRATE issue in METAnalyzer #32041

Merged
merged 2 commits into from Nov 6, 2020
Merged

Conversation

iatakisi
Copy link
Contributor

@iatakisi iatakisi commented Nov 5, 2020

------- PR description:

To solve the problem of incorrect METRATE calculation, the proposed changes are made.
Please see the issue in the following topic:
METAnalyzer::makeRatePlot calculation incorrect #29187
#29187
We do not expect any change in other plots but only METRate plots in collections

-------- PR validation:
The code is tested locally with UL data

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32041/19592

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32041/19593

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

A new Pull Request was created by @iatakisi for master.

It involves the following packages:

DQMOffline/JetMET

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@mmarionncern, @ahinzmann, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 5, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

+1
Tested at: 2a989f4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-126962/10535/summary.html
CMSSW: CMSSW_11_2_X_2020-11-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-126962/10535/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 229
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2543893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 6, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8367e1d into cms-sw:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants