Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disp mu mu producer #32044

Merged
merged 2 commits into from Nov 9, 2020
Merged

Conversation

jsalfeld
Copy link
Contributor

@jsalfeld jsalfeld commented Nov 6, 2020

PR description:

In its current version, the HLTDisplacedmumuVtxProducer requires matching of the input muons with objects passing a filter. It is not always useful to run a filter prior to the vertex producer I believe, and hence I make this optional.

This pull request is intended to remove the dependency of running a filter prior to the HLTDisplacedmumuVtxProducer

PR validation:

I checked compilation in 11_2_0_pre8, and functionality in CMSSW_11_1_0 where the same results for displaced vertices are present and muons are present before and after the change in the scouting event content.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32044/19606

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for master.

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @Martin-Grunewald, @JyothsnaKomaragiri, @ferencek, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

+1
Tested at: d238afe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f57bb1/10548/summary.html
CMSSW: CMSSW_11_2_X_2020-11-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f57bb1/10548/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544144
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544115
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 92154ca into cms-sw:master Nov 9, 2020
@jsalfeld
Copy link
Contributor Author

jsalfeld commented Nov 9, 2020

@silviodonato, @dpiparo, @qliphy, @Martin-Grunewald Can we back port this to CMSSW_11_1_0 ?

@qliphy
Copy link
Contributor

qliphy commented Nov 10, 2020

@jsalfeld Yes. Please note we plan to make the next 11_1_X release by this Friday for the next MWGR.

@jsalfeld
Copy link
Contributor Author

@jsalfeld Yes. Please note we plan to make the next 11_1_X release by this Friday for the next MWGR.

Thanks a lot @qliphy , the PR is here #32075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants