Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC RecHit Builder updates #32052

Merged
merged 24 commits into from Nov 21, 2020
Merged

CSC RecHit Builder updates #32052

merged 24 commits into from Nov 21, 2020

Conversation

nvoytish
Copy link
Contributor

@nvoytish nvoytish commented Nov 6, 2020

PR description:

This PR adds some features to the CSC RecHit Builder.

The addressed problems are:

  • simple two overlapped signals delimitation in terms of the strip coordinate;
  • improvement of the hit reconstruction in the extreme wire groups of chamber(best improvement for ME11);
  • ME11 transition region hit reconstruction improvement.

For details see:
https://indico.cern.ch/event/968978/contributions/4078288/attachments/2133771/3594383/20_10_30-Voytishin_Palichik-CSC_rh_builder_improvement_updates.pdf

Adjusting RecHit reco for edge wire groups. Best improvement is obtained for the first and last wire group of ME11 station. For details see https://indico.cern.ch/event/968978/contributions/4078288/attachments/2133771/3594383/20_10_30-Voytishin_Palichik-CSC_rh_builder_improvement_updates.pdf
The procedure for two overlapped signal delimitation added. In case there is a hidden signal near the main maxima of the cluster, the wide cluster is divided in two and two strip hits are reconstructed from this. For details see https://indico.cern.ch/event/968978/contributions/4078288/attachments/2133771/3594383/20_10_30-Voytishin_Palichik-CSC_rh_builder_improvement_updates.pdf
The check isInFiducial() is made looser for the ME11 transition region. Used previously for getting rid of additional hits from ganged strips. As the ganging was omitted from the ME11, the check was causing inefficiency in the transition region. For details see https://indico.cern.ch/event/968978/contributions/4078288/attachments/2133771/3594383/20_10_30-Voytishin_Palichik-CSC_rh_builder_improvement_updates.pdf
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@nvoytish
Copy link
Contributor Author

nvoytish commented Nov 6, 2020

adding @ptcox as co-author

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

-code-checks

ERROR: Build errors found during clang-tidy run.

RecoLocalMuon/CSCRecHitD/src/CSCMake2DRecHit.cc:159:74: error: use of undeclared identifier 'wilo'; did you mean 'wglo'? [clang-diagnostic-error]
    lp0 = (layergeom_->possibleRecHitPosition( float(centerStrip) - 0.5, wilo, wihi )).first;
                                                                         ^~~~
                                                                         wglo
--
RecoLocalMuon/CSCRecHitD/src/CSCMake2DRecHit.cc:159:80: error: use of undeclared identifier 'wihi'; did you mean 'wghi'? [clang-diagnostic-error]
    lp0 = (layergeom_->possibleRecHitPosition( float(centerStrip) - 0.5, wilo, wihi )).first;
                                                                               ^~~~
                                                                               wghi
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32052/19639

  • This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #32052 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2020

@nvoytish
please post a message when you are done with updates in this PR.

@nvoytish
Copy link
Contributor Author

@nvoytish
please post a message when you are done with updates in this PR.

Hi, @slava77 ! If I didn't miss any issues, it looks like I am done with updates.

@slava77
Copy link
Contributor

slava77 commented Nov 20, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: b0c4ff2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f461d2/10914/summary.html
CMSSW: CMSSW_11_2_X_2020-11-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f461d2/10914/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7145 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2962300
  • DQMHistoTests: Total failures: 37565
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2924713
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 21, 2020

+1

for #32199 cf54157

  • updates are in line with the details presented in the reco meeting (see the link in the PR description)
  • jenkins tests pass and comparisons with the baseline show differences starting from somewhat small changes in the cscSegments and propagating to downstream quantities. As expected, there are more segments and the segments are longer.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 21, 2020

+1

@cmsbuild cmsbuild merged commit dbfa326 into cms-sw:master Nov 21, 2020
@makortel
Copy link
Contributor

makortel commented Nov 25, 2020

This PR might be causing heap-buffer-overflow failures in ASAN build in CSCXonStrip_MatchGatti::estimated2GattiCorrection(), please see #32274.

nvoytish added a commit to nvoytish/cmssw that referenced this pull request Dec 10, 2020
Fix of issue cms-sw#32274
caused by changes in PR cms-sw#32052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants