Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add customisation for pixel gains to 11_1_X #32057

Merged
merged 2 commits into from Nov 10, 2020

Conversation

jsalfeld
Copy link
Contributor

@jsalfeld jsalfeld commented Nov 8, 2020

PR description:

adding pixel gain customisation at HLT to 11_1_X.

backport of #31655

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2020

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+1
Tested at: e27e2e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7e96/10580/summary.html
CMSSW: CMSSW_11_1_X_2020-11-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7e96/10580/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784776
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784725
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

@jsalfeld please make a PR for master. We can backport a PR in 11_1 only after having merged it in master

@fwyzard
Copy link
Contributor

fwyzard commented Nov 9, 2020

@silviodonato this PR is a (partial) backport of #31655

@jsalfeld could you add also the customiseFor2018Input function from that same PR ?

def customiseFor2018Input(process):
    """Customise the HLT to run on Run 2 data/MC"""
    process = customisePixelGainForRun2Input(process)
    process = synchronizeHCALHLTofflineRun3on2018data(process)

@silviodonato
Copy link
Contributor

backport of #31655

@cmsbuild
Copy link
Contributor

Pull request #32057 was updated. @Martin-Grunewald, @cmsbuild, @fwyzard can you please check and sign again.

@jsalfeld
Copy link
Contributor Author

@silviodonato this PR is a (partial) backport of #31655

@jsalfeld could you add also the customiseFor2018Input function from that same PR ?

def customiseFor2018Input(process):
    """Customise the HLT to run on Run 2 data/MC"""
    process = customisePixelGainForRun2Input(process)
    process = synchronizeHCALHLTofflineRun3on2018data(process)

@fwyzard my recent commit should add the function, if I understand correctly

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 65dd5a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7e96/10615/summary.html
CMSSW: CMSSW_11_1_X_2020-11-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7e96/10615/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bfb054f into cms-sw:CMSSW_11_1_X Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants