Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use integer as keyword in weightsQIE11 PSet #32067

Merged
merged 6 commits into from Nov 13, 2020
Merged

Do not use integer as keyword in weightsQIE11 PSet #32067

merged 6 commits into from Nov 13, 2020

Conversation

JHiltbrand
Copy link
Contributor

PR description:

In response to #32047, I have removed the use of just a simple integer (inside a string) when specifying the weightsQIE11 PSet.
Although things currently work as is, using a bare integer breaks things when dumping out the config via edmConfigDump. I simply append string "ieta" to the bare integers and now the dumped out config also should work.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Nov 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

The code-checks are being triggered in jenkins.

@JHiltbrand JHiltbrand mentioned this pull request Nov 9, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32067/19685

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

A new Pull Request was created by @JHiltbrand (Joshua Hiltbrand) for master.

It involves the following packages:

SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@abdoulline, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020 •
edited

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

From https://github.com/cms-sw/cmssw/blob/master/SimCalorimetry/HcalTrigPrimProducers/src/HcalTrigPrimDigiProducer.cc#L48 I see that weightsQIE11 parameter is not optional.
I would suggest to move it to a tracked parameter.

@JHiltbrand
Copy link
Contributor Author

JHiltbrand commented Nov 9, 2020 •
edited

From https://github.com/cms-sw/cmssw/blob/master/SimCalorimetry/HcalTrigPrimProducers/src/HcalTrigPrimDigiProducer.cc#L48 I see that weightsQIE11 parameter is not optional.
I would suggest to move it to a tracked parameter.

Ah, can do.

@cms-sw cms-sw deleted a comment from cmsbuild Nov 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32067/19706

  • This PR adds an extra 28KB to repository

@JHiltbrand
Copy link
Contributor Author

Ok, I believe I have addressed open concerns. I also added a small fix (1f286f9) for when running with non-default filters (for future).

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32067/19728

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32067 was updated. @cmsbuild, @rekovic, @jmduarte can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 665c124
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0570b/10618/summary.html
CMSSW: CMSSW_11_2_X_2020-11-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0570b/10618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020 •
edited

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

@cms-sw/l1-l2 do you have any comments? I'm going to include this in pre9

@cmsbuild
Copy link
Contributor

+1
Tested at: 1f286f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0570b/10638/summary.html
CMSSW: CMSSW_11_2_X_2020-11-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0570b/10638/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529273
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 03ff469 into cms-sw:master Nov 13, 2020
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Nov 15, 2020
@fwyzard
Backport: do not use integer as keyword in weightsQIE11 PSet (cms-sw#…
bc403a0 
…32067)
@JHiltbrand JHiltbrand deleted the fixWeightsQIE11PSet branch September 13, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinInn VinInn VinInn left review comments

@silviodonato silviodonato silviodonato left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JHiltbrand @cmsbuild @silviodonato @VinInn