New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch l1tstage2 DQM client to run3 #32132
Switch l1tstage2 DQM client to run3 #32132
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32132/19800
|
A new Pull Request was created by @benkrikler for master. It involves the following packages: DQM/Integration @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @benkrikler, @jfernan2, Thanks! This should be used in the MWGR next week. I assume we need a backport to 11_1_X? Cheers, |
Hi @dinyar |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is to migrate the stage2 L1Trigger DQM code to use the Run3 era modifiers. Changes should be minimal at this point and from my tests this seems correct.
Relates to this PR from @dinyar #31951
PR validation:
I have tested this PR running the clients on a specific run and compared the outputs - things seem as expected to me.