Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Extended2023Pixel #3214

Merged
merged 3 commits into from Apr 4, 2014

Conversation

mark-grimes
Copy link

Extended2023Pixel references some files in BarrelEndcap5D despite having the extended pixel detector. This fixes the 136xx tests. There are still two BarrelEndcap5D files used - BarrelEndcap5D/pixbar.xml and BarrelEndcap5D/tracker.xml. After discussion with @boudoul, it seems these two files are shared between both detectors.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Fix Extended2023Pixel

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Tested together with #3185 and #3202.
Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800 and 13000 pass all steps.
Tests 12200, 12400, 12600, 13200, 13400, 13800, 14000, 14200 and 14400 fail in step 2 with known errors.
Test 13600 now passes all steps whereas it used to crash in step 3.

cmsbuild added a commit that referenced this pull request Apr 4, 2014
@cmsbuild cmsbuild merged commit 9760756 into cms-sw:CMSSW_6_2_X_SLHC Apr 4, 2014
@mark-grimes mark-grimes deleted the fixExtendedPixel2023 branch April 7, 2014 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants