Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments describing the ConvertingESProducer[WithDependencies]T class templates #32149

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 15, 2020

PR description:

Add comments describing the ConvertingESProducerT and ConvertingESProducerWithDependenciesT class templates.

PR validation:

None - add only comments.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 15, 2020

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32149/19820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDACore

@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: b4369a0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55091f/10765/summary.html
CMSSW: CMSSW_11_2_X_2020-11-15-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 15, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55091f/10765/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 16, 2020

+1

@cmsbuild cmsbuild merged commit 72c51d7 into cms-sw:master Nov 16, 2020
@fwyzard fwyzard deleted the HeterogeneousCore_ConvertingESProducerT branch December 27, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants