New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a never used (and wrongly defined) constant from HcalTopology.h #32204
Conversation
Replace a never used variable, moreover declared as unsigned int but initialized with a negative number (which generates a compilation warning)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32204/19946
|
A new Pull Request was created by @perrotta for master. It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Remove a never used constant, which is moreover declared as unsigned int but initialized with a negative number (which generates a compilation warning)