Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QGL tag for 2016 and 2018 MC and Run 2 data #32224

Merged
merged 1 commit into from Nov 23, 2020

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates the quark-gluon likelihood tag for 2016 and 2018 MC and Run 2 data; 2017 MC already has the correct tag. The update has already been included in the 102X series for the nanoAOD campaign but the change was never propagated to 10_6_X and master.

See the HN thread for details.

This PR may or may not be final. I have requested clarification from QGL experts whether Run 3 MC should receive this update as well. However, since the Run 3 updates will not be backported to 10_6_X, the portion that will be backported to 10_6_X is final.

The GT diffs are as follows:

Run 1 proton-heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun1_pA_v1/112X_mcRun1_pA_v2

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_preVFP_v1/112X_mcRun2_asymptotic_preVFP_v2

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_v1/112X_mcRun2_asymptotic_v2

2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2cosmics_asymptotic_deco_v1/112X_mcRun2cosmics_asymptotic_deco_v2

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_v6/112X_dataRun2_v7

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HEfail_v6/112X_dataRun2_HEfail_v7

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_relval_v6/112X_dataRun2_relval_v7

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v5/112X_upgrade2018_realistic_v6

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v5/112X_upgrade2018_realistic_HEfail_v6

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v5/112X_upgrade2018cosmics_realistic_deco_v6

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v5/112X_upgrade2018cosmics_realistic_peak_v6

There is an additional technical update in this PR to the Run 1 proton-HI GT to remove the obsolete record of type PGeometricDetExtraRcd that is no longer defined. This should have been done in PR #31780. The problem was not noticed because the autoCond key run1_mc_pa is not used anywhere in CMSSW.

PR validation:

These tags have already been validated and are in use in the 10_2_X series.

In addition, a technical test was performed: runTheMatrix.py -l limited,1325.516,7.22,136.8642,11024.2,7.4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but will be backported to 10_6_X.

@christopheralanwest
Copy link
Contributor Author

test parameters

  • workflow = 1325.516,7.22,136.8642,11024.2,7.4

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32224/19976

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 197fdda
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90b86b/10921/summary.html
CMSSW: CMSSW_11_2_X_2020-11-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90b86b/10921/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-90b86b/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-90b86b/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-90b86b/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2961011
  • DQMHistoTests: Total failures: 47
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2960941
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor Author

I didn't expect to see differences in AK4 jets in Run 1 workflows 4.53 and 1000.0. For example, see one of the differences in comparison tests in workflow 1000.0:

JetMET/Jet/Cleanedak4PFJetsCHS/qg_Likelihood_mediumPt_Barrel
JetMET__Jet_Cleanedak4PFJetsCHS_DiJet_qg_Likelihood_mediumPt_Barrel

I will check with experts to see if we need to preserve the current QG likelihood values for AK4 jets for Run 1 or if consistency is not required because AK4 jets are not supported for Run 1.

@christopheralanwest christopheralanwest marked this pull request as ready for review November 23, 2020 17:57
@christopheralanwest
Copy link
Contributor Author

+1

  • QGL tags now consistent with those in 10_2_X
  • changes in PR comparison tests only in expected distributions and workflows (QGL experts confirmed that differences in Run 1 AK4 distributions are OK)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants