New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update QGL tag for 2016 and 2018 MC and Run 2 data #32224
Update QGL tag for 2016 and 2018 MC and Run 2 data #32224
Conversation
test parameters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32224/19976
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/AlCa @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
I didn't expect to see differences in AK4 jets in Run 1 workflows 4.53 and 1000.0. For example, see one of the differences in comparison tests in workflow 1000.0:
I will check with experts to see if we need to preserve the current QG likelihood values for AK4 jets for Run 1 or if consistency is not required because AK4 jets are not supported for Run 1. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates the quark-gluon likelihood tag for 2016 and 2018 MC and Run 2 data; 2017 MC already has the correct tag. The update has already been included in the 102X series for the nanoAOD campaign but the change was never propagated to 10_6_X and master.
See the HN thread for details.
This PR may or may not be final. I have requested clarification from QGL experts whether Run 3 MC should receive this update as well. However, since the Run 3 updates will not be backported to 10_6_X, the portion that will be backported to 10_6_X is final.
The GT diffs are as follows:
Run 1 proton-heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun1_pA_v1/112X_mcRun1_pA_v2
2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_preVFP_v1/112X_mcRun2_asymptotic_preVFP_v2
2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2_asymptotic_v1/112X_mcRun2_asymptotic_v2
2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun2cosmics_asymptotic_deco_v1/112X_mcRun2cosmics_asymptotic_deco_v2
Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_v6/112X_dataRun2_v7
Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HEfail_v6/112X_dataRun2_HEfail_v7
Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_relval_v6/112X_dataRun2_relval_v7
2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_v5/112X_upgrade2018_realistic_v6
2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018_realistic_HEfail_v5/112X_upgrade2018_realistic_HEfail_v6
2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_deco_v5/112X_upgrade2018cosmics_realistic_deco_v6
2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_upgrade2018cosmics_realistic_peak_v5/112X_upgrade2018cosmics_realistic_peak_v6
There is an additional technical update in this PR to the Run 1 proton-HI GT to remove the obsolete record of type
PGeometricDetExtraRcd
that is no longer defined. This should have been done in PR #31780. The problem was not noticed because the autoCond keyrun1_mc_pa
is not used anywhere in CMSSW.PR validation:
These tags have already been validated and are in use in the 10_2_X series.
In addition, a technical test was performed:
runTheMatrix.py -l limited,1325.516,7.22,136.8642,11024.2,7.4 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport but will be backported to 10_6_X.