Remove FastSim dependecy in Validation/RecoParticleFlow/plugins/PFAnalysis.cc

[silviodonato]

PR description:

This PR removes the FastSim dependency in Validation/RecoParticleFlow/plugins/PFAnalysis.cc by replacing Transform3DPJ with Transform3D from root. This PR fixes the error

  ****ERROR: Dependency violation (direct): Validation/RecoParticleFlow/plugins/PFAnalysis.cc FastSimulation/CaloGeometryTools/interface/Transform3DPJ.h
  *Validation/RecoParticleFlow/plugins/PFAnalysis.cc (Validation/RecoParticleFlow/plugins/PFAnalysis.cc)
    *FastSimulation/CaloGeometryTools/interface/Transform3DPJ.h (FastSimulation/CaloGeometryTools/interface/Transform3DPJ.h)

See https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-11-23-2300/depViolationLogs/Validation/RecoParticleFlow

PR validation:

I tested ReleaseDepsChecks.pland the errors has disappeared after the fix .

[silviodonato]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32258/20024

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10986/console Started: 2020/11/24 14:41

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

this doesn't seem like a dependency we want? In any case it looks like Transform3DPJ.h is just copied from root - perhaps the better solution is to depend on root directly;

#26016

[silviodonato]

Thanks David, I've implemented your suggestion

[silviodonato]

please abort

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32258/20027

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #32258 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10993/console Started: 2020/11/24 16:12

[silviodonato]

please test
@jfernan2 that is the DD4HEP workflows, that as some problems. Let's try to run it one more time ( see #32249 )

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11006/console Started: 2020/11/24 20:40

[cmsbuild]

+1
Tested at: 71e9ea9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4b4ec/11006/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4b4ec/11006/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2963481
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[jfernan2]

+1
Thanks @silviodonato !

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1