Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge remaining .h files with .cc plugin files in EgammaIsolationAlogs #32362

Merged
merged 1 commit into from Dec 7, 2020
Merged

Merge remaining .h files with .cc plugin files in EgammaIsolationAlogs #32362

merged 1 commit into from Dec 7, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

This PR merges the remaining .h files with .cc files in EgammaIsolationAlogs plugins, following up on #32259. I have done this for several packages in egamma and PF before, as it is recommended by the code guidelines and indeed makes the maintenance of plugins easier. In particular, dealing with the includes and the ESGetToken migration.

The previous PR addressed the EDM producer plugins, while this PR covers the IsoDepositExtractor plugins. To make them distinct from the producer plugins, they were put in a new subdirectory iso_deposit_extractors, similar to the existing isolation_cones directory.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32362/20207

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @varuns23, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Dec 3, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-273d75/11317/summary.html
CMSSW: CMSSW_11_3_X_2020-12-03-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-273d75/11317/summary.html
CMSSW: CMSSW_11_3_X_2020-12-03-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2529564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@jpata
Copy link
Contributor

jpata commented Dec 7, 2020

+reconstruction

  • technical, rearranges EgammaIsolationAlogs plugins from .h to .cc files
  • no changes expected or observed

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 7, 2020

+1

@cmsbuild cmsbuild merged commit a8da625 into cms-sw:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants