New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge remaining .h files with .cc plugin files in EgammaIsolationAlogs #32362
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32362/20207
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEgamma/EgammaIsolationAlgos @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 |
Comparison results are now available Comparison Summary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR merges the remaining .h files with .cc files in EgammaIsolationAlogs plugins, following up on #32259. I have done this for several packages in egamma and PF before, as it is recommended by the code guidelines and indeed makes the maintenance of plugins easier. In particular, dealing with the includes and the ESGetToken migration.
The previous PR addressed the EDM producer plugins, while this PR covers the IsoDepositExtractor plugins. To make them distinct from the producer plugins, they were put in a new subdirectory
iso_deposit_extractors
, similar to the existingisolation_cones
directory.PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.