Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in TauAnalysis/MCEmbeddingTools/python/customisers.py (lowPtGsfElectronTask) #32400

Merged

Conversation

silviodonato
Copy link
Contributor

This PR fixes the unit test failure in TauAnalysis/MCEmbeddingTools(see #32376).
This PR consists in removing three tasks (slimmedLowPtElectronsTask, lowPtGsfElectronTask, gsfTracksOpenConversions) added by #31220.

Validated by running

cmsDriver.py MERGE -s PAT --filein file:simulated_and_cleaned.root  --fileout file:merged.root --era Run2_2016_HIPM --data --scenario pp --conditions auto:run2_data --eventcontent  MINIAODSIM --datatier USER --customise TauAnalysis/MCEmbeddingTools/customisers.customiseMerging --customise_commands "process.patTrigger.processName = cms.string('SIMembedding')" -n -1 

after having run TauAnalysis/MCEmbeddingTools/test/runtests.sh.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32400/20268

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

TauAnalysis/MCEmbeddingTools

@cmsbuild, @civanch, @santocch, @mdhildreth can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

@kandrosov @roger-wolf do you have any comments?
cc: @swayand (author of #17095)

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bd057/11381/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bd057/11381/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2746991
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@civanch
Copy link
Contributor

civanch commented Dec 7, 2020

+1

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit b3a51e1 into cms-sw:master Dec 8, 2020
@santocch
Copy link

santocch commented Dec 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants