Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular dependency between CommonTools and JetMETCorrections subsystems #32401

Merged
merged 1 commit into from Dec 10, 2020
Merged

Break circular dependency between CommonTools and JetMETCorrections subsystems #32401

merged 1 commit into from Dec 10, 2020

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Dec 7, 2020

PR description:

It would be good if the dependencies of the packages in the CommonTools subsystem are reduced a bit, given that to many other packages depend on CommonTools.

This PR suggests to break the circular circular dependency between CommonTools and JetMETCorrections (note: it's not a dependency circle at the package level, only at the level of subsystems).

PR validation:

CMSSW complies.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32401/20269

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CommonTools/ParticleFlow
JetMETCorrections/JetCorrector
JetMETCorrections/Type1MET
Validation/RecoTrack

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @wmtford, @seemasharmafnal, @mmarionncern, @makortel, @JanFSchulte, @jdolen, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @mtosi, @dgulhan, @clelange, @ahinzmann, @hatakeyamak, @cbernet, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36514b/11392/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2020

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36514b/11392/summary.html
CMSSW: CMSSW_11_3_X_2020-12-05-1100
SCRAM_ARCH: slc7_amd64_gcc900

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747014
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2746991
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 8, 2020

+1

@santocch
Copy link

santocch commented Dec 9, 2020

+1

@jpata
Copy link
Contributor

jpata commented Dec 10, 2020

+reconstruction

  • technical, moves code from CommonTools/ParticleFlow to JetMETCorrections/JetCorrector
  • no changes expected or observed in workflows
  • note that there are some potential conflicts with other PRs, it's probably better to merge DeepCore (NN jetCore seeding) implementation  #32222 first, and then fix the conflicts in this PR here

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 69d8a54 into cms-sw:master Dec 10, 2020
@guitargeek guitargeek deleted the CommonTools_JetMETCorrections_1 branch December 10, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants