New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break circular dependency between CommonTools and JetMETCorrections subsystems #32401
Break circular dependency between CommonTools and JetMETCorrections subsystems #32401
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32401/20269
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CommonTools/ParticleFlow @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 |
Comparison results are now available Comparison Summary:
|
+1 |
+1 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
It would be good if the dependencies of the packages in the CommonTools subsystem are reduced a bit, given that to many other packages depend on CommonTools.
This PR suggests to break the circular circular dependency between CommonTools and JetMETCorrections (note: it's not a dependency circle at the package level, only at the level of subsystems).
PR validation:
CMSSW complies.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.