New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run4-hgx270 Add tile attributes to scintillator DetId #32433
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32433/20314
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32433/20315
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 |
Comparison results are now available Comparison Summary:
|
+1 |
+1 |
@kpedro88 Could you approve this? |
@@ -0,0 +1,4751 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda this is a rather large file. Is there any way the information in this file can be encoded more concisely? (I'm mainly concerned that if every new HGCal geometry requires a similar file, it will become a non-trivial portion of the entire repository.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall try in future. I shall retire V13 file once this is integrated. But that needs changes in the scenario declaration. I shall try to reduce the size in future releases.
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add tile attributes to scintillator DetId in the SIM step
PR validation:
Use runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special