Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Minuit logger for CMS MessageLogger #32440

Merged
merged 4 commits into from Dec 18, 2020

Conversation

mrodozov
Copy link
Contributor

PR description:

See #32416
This makes use of LogInfo to substitute Minuit logger which was updated
One concern is what happens with the
MnPrint::SetLevel(PrintLevel())
calls now commented since the old Minuit was globally setting the level and now MnPrint::SetLevel requires an object
From what I checked the LogInfo is used already within the same package:
https://github.com/cms-sw/cmssw/blob/master/RecoLocalCalo/HcalRecAlgos/src/HcalSeverityLevelComputer.cc#L292
nn the same manner.

PR validation:

it builds with latest ROOT master changes and it should work without MnPrint at all

@mrodozov mrodozov force-pushed the change-minuit-logger-with-cms-logger branch from e1b2312 to 311fc57 Compare December 10, 2020 17:26
@mrodozov
Copy link
Contributor Author

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32440/20330

  • This PR adds an extra 20KB to repository

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @apsallid, @thomreis, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@@ -169,16 +170,16 @@ namespace PSFitter {

if (step <= 0) {
std::string txtmsg = "Parameter " + name + " has zero or invalid step size - consider it as constant ";
MN_INFO_MSG2("HybridMinimizer::SetVariable", txtmsg);
edm::LogInfo("HybridMinimizer::SetVariable") << txtmsg << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The std::endl us unnecessary as MessageLogger adds the newline (unless intention is to have two newlines),

Suggested change
edm::LogInfo("HybridMinimizer::SetVariable") << txtmsg << std::endl;
edm::LogInfo("HybridMinimizer::SetVariable") << txtmsg;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, would it be worth to avoid the intermediate string?

edm::LogInfo("HybridMinimizer::SetVariable") << "Parameter " << name << "  has zero or invalid step size - consider it as constant";

or

edm::LogInfo("HybridMinimizer::SetVariable").format("Parameter {} has zero or invalid step size - consider it as constant", name);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the test is finished I'll add it, finished tests will keep the root rpm and avoid rebuilding it.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32440/20332

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32440 was updated. @perrotta, @jpata, @slava77 can you please check and sign again.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32440/20338

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32440/20465

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32440/20467

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32440 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Dec 17, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8085b/11769/summary.html
CMSSW: CMSSW_11_3_X_2020-12-17-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747287
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2747255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 17, 2020

+1

for #32440 508c123

  • the switch to CMS EMD message logging seems acceptable
  • jenkins tests pass and comparisons with the baseline show no relevant differences; none are expected (IIRC, the modified code is not running bu default; it's enabled with useM2 parameter in HBHEPhase1Reconstructor)

issue #32525 was added to keep track of possibly more appropriate treatment of the HybridMinimizer

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 18, 2020

+1

@cmsbuild cmsbuild merged commit 4f7462b into cms-sw:master Dec 18, 2020
@mrodozov mrodozov deleted the change-minuit-logger-with-cms-logger branch January 28, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants