Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Era support for the BMTF Packer #32455

Conversation

panoskatsoulis
Copy link
Contributor

backport of #32365

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2020

A new Pull Request was created by @panoskatsoulis (Panos) for CMSSW_11_2_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@panoskatsoulis
Copy link
Contributor Author

This PR stands instead of the previous #32367 that was closed.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbf61a/11551/summary.html
CMSSW: CMSSW_11_2_X_2020-12-11-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 197
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529373
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

urgent

@silviodonato
Copy link
Contributor

cc: @BenjaminRS @bundocka @cbotta

@silviodonato
Copy link
Contributor

backport of #32455

@rekovic
Copy link
Contributor

rekovic commented Dec 15, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 16, 2020

+1

@cmsbuild cmsbuild merged commit d8beb9b into cms-sw:CMSSW_11_2_X Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants