Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCal ID variables #32517

Merged

Conversation

SohamBhattacharya
Copy link
Contributor

@SohamBhattacharya SohamBhattacharya commented Dec 17, 2020

PR description:

This is a backport of PR #32519.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2020

A new Pull Request was created by @SohamBhattacharya for CMSSW_11_1_X.

It involves the following packages:

RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaTools

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@Sam-Harper, @sobhatta, @jainshilpi, @Fedespring, @lgray, @calderona, @HuguesBrun, @afiqaize, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Dec 17, 2020

please test

@fwyzard
Copy link
Contributor

fwyzard commented Dec 17, 2020

@SohamBhattacharya is there a corresponding PR for master / 11.3.x ?

@fwyzard
Copy link
Contributor

fwyzard commented Dec 17, 2020

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32517/20461

  • This PR adds an extra 24KB to repository

This was referenced Dec 17, 2020
@SohamBhattacharya
Copy link
Contributor Author

@SohamBhattacharya is there a corresponding PR for master / 11.3.x ?

@fwyzard Yes, I have just submitted the PRs for 11_3_x (#32519) and 11_2_X (#32520).

@cmsbuild
Copy link
Contributor

Pull request #32517 was updated. @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please check and sign again.

@silviodonato
Copy link
Contributor

urgent
for the HLT TDR release (11_1_X)

@silviodonato
Copy link
Contributor

please test


double cylinderR2 = cylinderR * cylinderR;

double Rvar = 0.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in #32519, it should be rVar

@cmsbuild
Copy link
Contributor

Pull request #32517 was updated. @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Jan 11, 2021

@cmsbuild please test

@SohamBhattacharya can you confirm that the latest version, post updates, runs successfully in the HLT setup in 11_1_X?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a90d/12053/summary.html
COMMIT: d53d8c9
CMSSW: CMSSW_11_1_X_2021-01-10-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@SohamBhattacharya
Copy link
Contributor Author

@cmsbuild please test

@SohamBhattacharya can you confirm that the latest version, post updates, runs successfully in the HLT setup in 11_1_X?

@jpata Yes, the latest version as of now, runs successfully in the HLT setup in 11_1_X (the test config described in #32519 runs successfully in 11_1_X).

@jpata
Copy link
Contributor

jpata commented Jan 12, 2021

+reconstruction

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 13, 2021

+1

@cmsbuild cmsbuild merged commit 03f7e34 into cms-sw:CMSSW_11_1_X Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants