New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGCal ID variables #32517
HGCal ID variables #32517
Conversation
adding HGCalClusterTools and HGCalID variable producer
A new Pull Request was created by @SohamBhattacharya for CMSSW_11_1_X. It involves the following packages: RecoEgamma/EgammaHLTProducers @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
@SohamBhattacharya is there a corresponding PR for master / 11.3.x ? |
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32517/20461
|
@fwyzard Yes, I have just submitted the PRs for 11_3_x (#32519) and 11_2_X (#32520). |
urgent |
please test |
|
||
double cylinderR2 = cylinderR * cylinderR; | ||
|
||
double Rvar = 0.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in #32519, it should be rVar
@cmsbuild please test @SohamBhattacharya can you confirm that the latest version, post updates, runs successfully in the HLT setup in 11_1_X? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5a90d/12053/summary.html Comparison SummarySummary:
|
@jpata Yes, the latest version as of now, runs successfully in the HLT setup in 11_1_X (the test config described in #32519 runs successfully in 11_1_X). |
+reconstruction
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a backport of PR #32519.