New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCal] [bugfix] fix NaN values in LeafCandidate rapidity #32524
[HGCal] [bugfix] fix NaN values in LeafCandidate rapidity #32524
Conversation
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32524/20476
|
A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master. It involves the following packages: RecoHGCal/TICL @perrotta, @jpata, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e21463/11771/summary.html Comparison SummarySummary:
|
@@ -296,7 +296,8 @@ void TrackstersMergeProducer::produce(edm::Event &evt, const edm::EventSetup &es | |||
} | |||
|
|||
// Neutral Hadrons | |||
constexpr float mpion2 = 0.13957f * 0.13957f; | |||
constexpr float mpion = 0.13957f; | |||
constexpr float mpion2 = mpion * mpion; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double? (to match signature or LorenzVector)
@@ -511,8 +512,8 @@ void TrackstersMergeProducer::produce(edm::Event &evt, const edm::EventSetup &es | |||
tmpCandidate.setPdgId(211 * track.charge()); | |||
float energy = std::sqrt(track.pt() * track.pt() + mpion2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this actually use track.p ?
float energy = std::sqrt(track.pt() * track.pt() + mpion2); | |
float energy = std::sqrt(track.p() * track.p() + mpion2); |
IIUC, this way even the original p4 definition would be correct.
or is there some good reason to keep raw energy to be this "transverse" energy?
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32524/20563
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e21463/11846/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes NaN values in the rapidity of LeafCandidates when charged hadrons are created from empty tracksters.
PR validation:
Tested in 23234.0 with the injection of TICL in PF:
--customise RecoHGCal/TICL/iterativeTICL_cff.injectTICLintoPF
@rovere @missirol @hatakeyamak @bendavid @hqucms