New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GPU workflows to a specific GPU matrix #32547
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32547/20503
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
10842.501,10842.502, # 10842.503,10842.504, | ||
10824.501,10824.502, # 10824.503,10824.504, | ||
10824.511,10824.512, # 10824.513,10824.514, | ||
10824.521,10824.522, # 10824.523,10824.524, | ||
10842.501, # 10842.503,10842.504, | ||
10824.501, # 10824.503,10824.504, | ||
10824.511, # 10824.513,10824.514, | ||
10824.521, # 10824.523,10824.524, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove also the (commented out) .503
, .513
, .523
etc. workflows ?
those will (eventually) run only on a GPU machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(here and in the other blocks, as well)
I'm not very familiar with the matrix configuration, but from a quick look I think it should work as intended. |
please abort |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32547/20504
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32547/20535
|
Pull request #32547 was updated. @chayanit, @wajidalikhan, @kpedro88, @jordan-martins can you please check and sign again. |
@fwyzard I've included |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9c955/11829/summary.html Comparison SummarySummary:
|
👍 |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Solve issue #32428
This PR creates a matrix for gpu (
runTheMatrix.py -w gpu
) and moves all*GPU*
workflows into it.Before PR
After PR