Added missing package dependency needed for UBSAN in JetMETCorrections/Type1MET

[Dr15Jones]

PR description:

A virtual table from the missing package is needed to run UBSAN.

PR validation:

Code links cleanly under UBSAN.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32552/20511

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

JetMETCorrections/Type1MET

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0063f/11802/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Use WaitingTaskHolder for function arguments #32510 @Dr15Jones: Use WaitingTaskHolder for function arguments
• Run3-gex44 Correct use of unit coversion for CaloGeometryLoader #32535 @bsunanda: Run3-gex44 Correct use of unit coversion for CaloGeometryLoader
• HLT menu migration to CMSSW_11_3_0_pre1 #32537 @cms-tsg-storm: HLT menu migration to CMSSW_11_3_0_pre1

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0063f/11802/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0063f/11802/git-merge-result

DAS Queries failed

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2716962
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.003 KiB( 35 files compared)
• DQMHistoSizes: changed ( 11624.911,... ): -0.001 KiB HLT/Filters
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass

[perrotta]

hold
(I see this dependency was also added in the more general #32562, while there the dependency was only included in the plugin area, and not to the whole JetMETCorrections/Type1MET package. I think it can be more convenient to decide which is the best location for the missing inclusion and unify all those additions in #32562)

[cmsbuild]

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[Dr15Jones]

(I see this dependency was also added in the more general #32562, while there the dependency was only included in the plugin area, and not to the whole JetMETCorrections/Type1MET package. I think it can be more convenient to decide which is the best location for the missing inclusion and unify all those additions in #32562)

@perrotta it only works here if it is done at the top most BuildFIle.xml. I tried to do it at the plugin level first but that failed.

[makortel]

Adding the dependence in plugins/BuildFile.xml worked for me. On the other hand, the dependence is brought in by a header in interface, so perhaps the top-level BuildFile.xml is the proper placement.

[perrotta]

unhold
(thank you @Dr15Jones and @makortel )

[silviodonato]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.