New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where ED module tasks started in the es task_arena. #32566
Conversation
This properly transfers ownership of the underlying task.
The previous change to use WaitingTaskHolders for the arguments of the function calls failed to keep the use of the needed WaitingTaskWithArenaHolder to launch the ED module tasks into the correct arena.
please test |
Unit tests for the framework run fine. |
NOTE: although this does touch header files, it does not change the binary API so it is possible to do runTheMatrix tests just by checking out FWCore/Framework and FWCore/Concurrency, applying this change and only compiling those two libraries. That is MUCH faster than checking out everything that uses the headers which were touched. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32566/20531
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Concurrency @makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent |
please test |
+1 (assuming test pass) |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
merge |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4cb1f2/11823/summary.html Comparison SummarySummary:
|
PR description:
This fixes a bug introduced in #32510 where a
WaitingTaskWithArenaHolder
was incorrectly replaced with aWaitingTaskHolder
.PR validation:
The code compiles. Further tests are underway.