New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Make special Sim script output stay same after DD4hep units change #32578
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32578/20568
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: SimG4CMS/CherenkovAnalysis @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32578/20570
|
Pull request #32578 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56dd60/11866/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR prepares two special-purpose scripts for the upcoming DD4hep units change. Code changes are made so that the output of the scripts will be the same before and after the DD4hep units change.
Note that the scripts
SimG4Core/PrintGeomInfo/test/python/runDD4HEP_cfg.py
andSimG4Core/PrintGeomInfo/test/python/runDDD_cfg.py
needed some fixes just to be able to run.PR validation:
The output of the scripts was compared between old DD and DD4hep and verified to be the same.
No backport is needed.