New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimCluster-LayerCluster associator implementation #32587
SimCluster-LayerCluster associator implementation #32587
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32587/20589
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32587/20590
|
A new Pull Request was created by @lecriste (Leonardo Cristella) for master. It involves the following packages: SimCalorimetry/HGCalAssociatorProducers @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c1c08/11878/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@civanch can you please review this PR? |
SimClusterAssociatorByEnergyScoreImpl::SimClusterAssociatorByEnergyScoreImpl( | ||
edm::EDProductGetter const& productGetter, | ||
bool hardScatterOnly, | ||
std::shared_ptr<hgcal::RecHitTools> recHitTools, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lecriste , you really need shared_ptr here? It is shared object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the producer is global, shared_ptr is OK.
+1 |
@cms-sw/upgrade-l2 can you please review this PR? |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR introduces an associator for HGCAL validation at SimCluster level, which will be used in a later PR. No changes are expected in the output.
PR validation:
runTheMatrix -l limited