New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS direct simulation: add 2021 profile #32602
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32602/20640
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: Geometry/VeryForwardData @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @ErnestaP, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ac0dc/11974/summary.html Comparison SummarySummary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds a 2021 profile to the "direct" simulation of PPS. This profile corresponds to our current best guess for Run3 start.
This PR also adds a default geometry (Roman Pot positions) file for Run3 with reasonable distances beam-RP:
PR validation:
Below two test comparisons.
PPS reco of Run2 data: not affected by this PR, as expected.
PPS direct simulation: