Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx283 Use ESGetToken in CalibCalorimetry/HcalPlugins #32605

Merged
merged 1 commit into from Jan 15, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 5, 2021

PR description:

Use ESGetToken in CalibCalorimetry/HcalPlugins

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32605/20649

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@christopheralanwest
Copy link
Contributor

please test

The tests were not started and this PR is not listed at https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904963/12240/summary.html
COMMIT: 9861d19
CMSSW: CMSSW_11_3_X_2021-01-12-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@yuanchao
Copy link
Contributor

+1

  • updated to use ESGetToken
  • matrix tests on work flow all passed
  • static build warning on std::vector thread-unsafe is not part of the modification

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@yuanchao
Copy link
Contributor

yuanchao commented Jan 14, 2021

(Sorry, posted on wrong PR)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5e05de2 into cms-sw:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants