New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] Thread-safe ES condition retrieval #32606
[PPS] Thread-safe ES condition retrieval #32606
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32606/20651
|
A new Pull Request was created by @forthommel (Laurent Forthomme) for master. It involves the following packages: RecoPPS/Local @perrotta, @andrius-k, @kmaeshima, @civanch, @ErnestaP, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2cddd/11985/summary.html Comparison SummarySummary:
|
It seems the only differences are found to be in the |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR replaces all
edm::EventSetup::get<TRcd>().get(..., edm::ESHandle<T>)
calls to the thread-safe equivalentT edm::EventSetup::getData(edm::ESGetToken<T, TRcd>)
member in the PPS environment (both in local reconstruction and validation codes).It also drops the
CTPPSPixelGainCalibrationDBService
helper object made trivial by this new retrieval method.PR validation:
Code compiles, runs, matrix tests all passing. Detailed validation (run 2 reco + direct simulation) performed by @jan-kaspar and successfully passing.
if this PR is a backport please specify the original PR and why you need to backport that PR: N/A
Before submitting your pull requests, make sure you followed this checklist: