Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce use of Worker::doWork #32607

Merged
merged 3 commits into from Jan 6, 2021
Merged

Reduce use of Worker::doWork #32607

merged 3 commits into from Jan 6, 2021

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Remove all but one call to Worker::doWork which is still used in the implementation of Event::getProvenance.
Worker::doWork is the only place that uses the pushAndWait ability of the task queues. In the migration to using tbb::task_group we would like to do away with pushAndWait.

There is one visible change seen by this PR, the TriggerResults EDProducer internal to the framework no longer sends a pre/post prefetch signal as it has no need for prefetching. This makes it behave like the EDProducers handling the individual Path results.

PR validation:

The code compiles and all framework unit tests pass.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32607/20652

  • This PR adds an extra 72KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf1863/11991/summary.html
COMMIT: 64f110e
CMSSW: CMSSW_11_3_X_2021-01-05-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716932
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@makortel
Copy link
Contributor

makortel commented Jan 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 6, 2021

+1

@cmsbuild cmsbuild merged commit 74d07a4 into cms-sw:master Jan 6, 2021
@Dr15Jones Dr15Jones deleted the removeDoWork branch January 7, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants