New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce use of Worker::doWork #32607
Reduce use of Worker::doWork #32607
Conversation
Called via runModuleDirectly instead of doWork.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32607/20652
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf1863/11991/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove all but one call to Worker::doWork which is still used in the implementation of Event::getProvenance.
Worker::doWork is the only place that uses the pushAndWait ability of the task queues. In the migration to using tbb::task_group we would like to do away with pushAndWait.
There is one visible change seen by this PR, the TriggerResults EDProducer internal to the framework no longer sends a pre/post prefetch signal as it has no need for prefetching. This makes it behave like the EDProducers handling the individual Path results.
PR validation:
The code compiles and all framework unit tests pass.