Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add root histpainter deps to fix UBSAN issue #32608

Merged
merged 1 commit into from Jan 7, 2021
Merged

add root histpainter deps to fix UBSAN issue #32608

merged 1 commit into from Jan 7, 2021

Conversation

smuzaffar
Copy link
Contributor

UBSAN IBs failed to build [a]. The issue ( reported by @Dr15Jones ) is that TPaletteAxis is defined in root's HistPainter lib for which we do not have any tool file. cms-sw/cmsdist#6533 adds new root tools and this PR suggest to add deps on roothistpainter to fix UBSAN link error.

gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/CondCore/SiStripPlugins/plugins/SiStripLorentzAngle_PayloadInspector/SiStripLorentzAngle_PayloadInspector.cc.o:(.data.rel+0x358): undefined reference to `typeinfo for TPaletteAxis'
collect2: error: ld returned 1 exit status

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#6533

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32608/20653

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1be35e/11993/summary.html
COMMIT: 6dfb31a
CMSSW: CMSSW_11_3_X_2021-01-05-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716941
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@smuzaffar
Copy link
Contributor Author

@silviodonato , @qliphy please merge this. This is just a technical change to explicitly link against the root's HistPainter library.

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants