Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker Alignment Payload Inspector: migration to new class templates #32609

Merged
merged 2 commits into from Jan 14, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 7, 2021

PR description:

This PR is purely technical. It consists of two commits:

  • f25417d migrates the Tracker Alignment Payload Inspector classes to new PayloadInspector class interfaces introduced in PR Improvements for Payload inspector #29622
  • ef0897d makes use of the namespace cond::payloadInspector in all CondCore/AlignmentPlugins plugins avoiding heavy repetitions in the code.

PR validation:

Relies on existing unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, not backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32609/20656

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/AlignmentPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 7, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f3e2/11997/summary.html
COMMIT: ef0897d
CMSSW: CMSSW_11_3_X_2021-01-06-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Jan 13, 2021

@ggovi ping?

@ggovi
Copy link
Contributor

ggovi commented Jan 14, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 14, 2021

+1

@cmsbuild cmsbuild merged commit 24a3b62 into cms-sw:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants