Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProdCuts and Sensitive detectors lists creation in DD4hep workflow #32612

Merged
merged 1 commit into from Jan 9, 2021

Conversation

ghugo83
Copy link
Contributor

@ghugo83 ghugo83 commented Jan 7, 2021

ProdCuts and sensitive detectors lists creation: Cannot compare names with namespace on one side and no namespace on the other side.
In practice, for all CMSSW ProdCuts and sens XMLs, and all scenarios, it is sufficient to compare names with no namespace.

PR check: This now makes the sensitive detectors lists identical for old DD versus DD4hep in full CMS.

…er side. In practice, for all CMSSW sens and ProdCuts XMLs and all scenarios, it is sufficient to compare with no namespace.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32612/20659

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2021

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

SimG4Core/Geometry

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jan 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a9def/12021/summary.html
COMMIT: 2d53061
CMSSW: CMSSW_11_3_X_2021-01-08-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@civanch
Copy link
Contributor

civanch commented Jan 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 9, 2021

+1

@cmsbuild cmsbuild merged commit f6665b9 into cms-sw:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants