Pps nano aod backport106 x #32616

jwill24 · 2021-01-07T22:10:00Z

PR description:

This is a backport for the PPS nanoAOD tables that were added to the 11_3_X branch (PR #31531).

The main changes are:

The naming scheme of the pps tracks "getter" functions in the ProtonProducer/ProtonFilter
Change from directory RecoPPS -> RecoCTPPS

cmsbuild · 2021-01-07T22:10:24Z

A new Pull Request was created by @jwill24 (Justin Williams) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
RecoCTPPS/ProtonReconstruction

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please review it and eventually sign? Thanks.
@gpetruc, @forthommel, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from PPS nanoAOD #31531

perrotta · 2021-01-08T07:12:40Z

backport of #31531

perrotta · 2021-01-08T07:16:32Z

@jwill24

please include also Range based loop in PPSFilteredProtonProducer #32521 in the backport
there are conflicts to fix (see the check report)

perrotta · 2021-01-08T07:19:22Z

PR description:

This is a backport for the PPS nanoAOD tables that were added to the 11_2_X branch (PR #31531).

@jwill24 : the PR #31531 was merged in 11_3_X, in fact. Only if you need it available also in 11_2_X, please prepare another backport for that release cycle

silviodonato · 2021-01-08T13:13:28Z

@jwill24 there is a conflict to be resolved. Probably another NanoAOD PR has been merged meanwhile

cmsbuild · 2021-01-08T14:49:16Z

Pull request #32616 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

jwill24 · 2021-01-08T14:49:25Z

@jwill24 there is a conflict to be resolved. Probably another NanoAOD PR has been merged meanwhile

The conflicts have been resolved.

mariadalfonso

still missing additional fix from #32616 (comment)

PhysicsTools/NanoAOD/plugins/BuildFile.xml

PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc

PhysicsTools/NanoAOD/python/protons_cff.py

mariadalfonso · 2021-01-08T18:15:09Z

please test

cmsbuild · 2021-01-08T19:18:55Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75946a/12030/summary.html
COMMIT: a659687
CMSSW: CMSSW_10_6_X_2021-01-08-1100/slc7_amd64_gcc700

RelVals

1325.81 step2

1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1.log

----- Begin Fatal Exception 08-Jan-2021 19:34:21 CET-----------------------
An exception of category 'MultiplePlugins' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'SimpleXYZPointFlatTableProducer' is found in multiple files 
 '"pluginPhysicsToolsNanoAODPlugins.so"'
 '"pluginPhysicsToolsNanoAODPlugins.so"'
in directory '/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32616/12030/CMSSW_10_6_X_2021-01-08-1100/lib/slc7_amd64_gcc700'.
The code must be changed so the plugin only appears in one plugin file. You will need to remove the macro which registers the plugin so it only appears in one of these files.
  If none of these files register such a plugin, then the problem originates in a library to which all these files link.
The plugin registration must be removed from that library since plugins are not allowed in regular libraries.
----- End Fatal Exception -------------------------------------------------

10824.0 step6

10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

----- Begin Fatal Exception 08-Jan-2021 19:59:18 CET-----------------------
An exception of category 'MultiplePlugins' occurred while
   [0] Constructing the EventProcessor
Exception Message:
The plugin 'SimpleXYZPointFlatTableProducer' is found in multiple files 
 '"pluginPhysicsToolsNanoAODPlugins.so"'
 '"pluginPhysicsToolsNanoAODPlugins.so"'
in directory '/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32616/12030/CMSSW_10_6_X_2021-01-08-1100/lib/slc7_amd64_gcc700'.
The code must be changed so the plugin only appears in one plugin file. You will need to remove the macro which registers the plugin so it only appears in one of these files.
  If none of these files register such a plugin, then the problem originates in a library to which all these files link.
The plugin registration must be removed from that library since plugins are not allowed in regular libraries.
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2021-01-11T18:30:45Z

Pull request #32616 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

perrotta · 2021-01-11T20:29:48Z

@jwill24

please include also Range based loop in PPSFilteredProtonProducer #32521 in the backport

jwill24 · 2021-01-12T15:26:31Z

@jwill24

please include also Range based loop in PPSFilteredProtonProducer #32521 in the backport

@perrotta Done

cmsbuild · 2021-01-12T15:26:35Z

Pull request #32616 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch can you please check and sign again.

perrotta · 2021-01-12T16:24:33Z

please test

cmsbuild · 2021-01-12T19:12:12Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75946a/12239/summary.html
COMMIT: f9d5b9a
CMSSW: CMSSW_10_6_X_2021-01-12-1100/slc7_amd64_gcc700

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215502
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215167
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 6.388 KiB( 34 files compared)
DQMHistoSizes: changed ( 1325.81,... ): 3.194 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files

cmsbuild · 2021-01-12T19:12:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75946a/12239/summary.html
COMMIT: f9d5b9a
CMSSW: CMSSW_10_6_X_2021-01-12-1100/slc7_amd64_gcc700

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215502
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215167
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 6.388 KiB( 34 files compared)
DQMHistoSizes: changed ( 1325.81,... ): 3.194 KiB Physics/NanoAODDQM
Checked 143 log files, 29 edm output root files, 35 DQM output files

perrotta · 2021-01-14T19:02:48Z

+1

The code for the filtered proton producer corresponds to the one merged in master (modulo different names for the PPS track getters which had been renamed between 10_6 and 11_3): this is fine with reco
Jenkins tests pass and show no differences in reco outputs wrt the baseline, as expected: the new plugin is only used for nanoAOD productions

mariadalfonso · 2021-01-17T12:47:24Z

+xpog

DQM results and timing consistent with master

cmsbuild · 2021-01-17T12:47:48Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-01-17T13:09:47Z

+1

juwillia added 2 commits January 7, 2021 20:24

Updated getter functions for pps track variables

e6658dd

Fixed compilation issue

1f56e23

cmsbuild added this to the CMSSW_10_6_X milestone Jan 7, 2021

cmsbuild added analysis-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Jan 7, 2021

cmsbuild added the backport-ok label Jan 8, 2021

jan-kaspar mentioned this pull request Jan 8, 2021

PPS nanoAOD #31531

Merged

mariadalfonso mentioned this pull request Jan 8, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

Merge branch 'CMSSW_10_6_X' into pps_nanoAOD_backport106X

a659687

mariadalfonso reviewed Jan 8, 2021

View reviewed changes

PhysicsTools/NanoAOD/plugins/BuildFile.xml Outdated Show resolved Hide resolved

PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc Show resolved Hide resolved

PhysicsTools/NanoAOD/python/protons_cff.py Outdated Show resolved Hide resolved

cmsbuild added tests-started and removed tests-pending labels Jan 8, 2021

cmsbuild added tests-rejected and removed tests-started labels Jan 8, 2021

changes following the comments from mariarasaria

ade2d14

cmsbuild added tests-pending and removed tests-rejected labels Jan 11, 2021

added range-based loop from PR cms-sw#32521

f9d5b9a

cmsbuild added tests-started and removed tests-pending labels Jan 12, 2021

cmsbuild added tests-approved and removed tests-started labels Jan 12, 2021

cmsbuild added reconstruction-approved and removed analysis-pending reconstruction-pending labels Jan 14, 2021

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jan 17, 2021

cmsbuild added orp-approved and removed orp-pending labels Jan 17, 2021

cmsbuild merged commit dade8e9 into cms-sw:CMSSW_10_6_X Jan 17, 2021

silviodonato mentioned this pull request Mar 24, 2021

Add nConstituents to fat jets. #32930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pps nano aod backport106 x #32616

Pps nano aod backport106 x #32616

jwill24 commented Jan 7, 2021 •

edited

cmsbuild commented Jan 7, 2021 •

edited

perrotta commented Jan 8, 2021

perrotta commented Jan 8, 2021

perrotta commented Jan 8, 2021

PR description:

silviodonato commented Jan 8, 2021

cmsbuild commented Jan 8, 2021

jwill24 commented Jan 8, 2021

mariadalfonso left a comment

mariadalfonso commented Jan 8, 2021

cmsbuild commented Jan 8, 2021

cmsbuild commented Jan 11, 2021

perrotta commented Jan 11, 2021

jwill24 commented Jan 12, 2021

cmsbuild commented Jan 12, 2021

perrotta commented Jan 12, 2021

cmsbuild commented Jan 12, 2021

cmsbuild commented Jan 12, 2021

perrotta commented Jan 14, 2021

mariadalfonso commented Jan 17, 2021

cmsbuild commented Jan 17, 2021

qliphy commented Jan 17, 2021

Pps nano aod backport106 x #32616

Pps nano aod backport106 x #32616

Conversation

jwill24 commented Jan 7, 2021 • edited

PR description:

cmsbuild commented Jan 7, 2021 • edited

perrotta commented Jan 8, 2021

perrotta commented Jan 8, 2021

perrotta commented Jan 8, 2021

PR description:

silviodonato commented Jan 8, 2021

cmsbuild commented Jan 8, 2021

jwill24 commented Jan 8, 2021

mariadalfonso left a comment

Choose a reason for hiding this comment

mariadalfonso commented Jan 8, 2021

cmsbuild commented Jan 8, 2021

RelVals

cmsbuild commented Jan 11, 2021

perrotta commented Jan 11, 2021

jwill24 commented Jan 12, 2021

cmsbuild commented Jan 12, 2021

perrotta commented Jan 12, 2021

cmsbuild commented Jan 12, 2021

Comparison Summary

cmsbuild commented Jan 12, 2021

Comparison Summary

perrotta commented Jan 14, 2021

mariadalfonso commented Jan 17, 2021

cmsbuild commented Jan 17, 2021

qliphy commented Jan 17, 2021

jwill24 commented Jan 7, 2021 •

edited

cmsbuild commented Jan 7, 2021 •

edited