Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: fix mtd.xml for scenario D49 for DD4hep compatibility #32617

Merged
merged 1 commit into from Jan 11, 2021

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Jan 8, 2021

PR description:

Addition of units where needed and missing in mtd.xml for scenario D49. The DD4hep porting of MTD geometry was based on the D50 test scenario, equivalent to D49 as far as MTD is concerned. This PR backports into the legacy baseline scenario a few needed fixes.

PR validation:

Unit test runs, showing identical results for both DDD and DD4hep

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32617/20668

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Jan 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-463d9f/12018/summary.html
COMMIT: 368d0d7
CMSSW: CMSSW_11_3_X_2021-01-07-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jan 8, 2021

+1

@srimanob
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 25c97ef into cms-sw:master Jan 11, 2021
@fabiocos fabiocos deleted the fc-D49dd4hep branch January 11, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants