Implement support for Event::getByToken for a GenericHandle

[fwyzard]

PR description:

Implement support for edm::Event::getByToken for an edm::GenericHandle.

PR validation:

None.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32620/20675

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Framework

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

As @fwyzard mentioned in mattermost, the implementations of the getByLabel() specializations have diverged from the generic getByLabel(), whereas the added getByToken() specialization follows the structure of the generic getByToken(). @Dr15Jones would you agree it would be good to update the getByLabel() specializations (in a separate PR unless @fwyzard would be willing to do that here as well)

[Dr15Jones]

If the differences are not actually functional (I can't really tell with a cursory look) than an update to make it consistent would make sense.

[makortel]

The only possibly functional difference I see is that the generic getByLabel() has this result.clear() call, while the specializations above do not have it.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-649f91/12036/summary.html
COMMIT: 5cffea5
CMSSW: CMSSW_11_3_X_2021-01-08-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1