Added include of cassert to Migration.h

[Dr15Jones]

PR description:

This is needed for the ROOT modules build.

PR validation:

The code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32622/20677

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DataFormats/CLHEP

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa6c04/12037/summary.html
COMMIT: dff0421
CMSSW: CMSSW_11_3_X_2021-01-08-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716929
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[makortel]

• Reco comparison results: 8 differences found in the comparisons

One of these is in workflow 1325.81 in nanoaodFlatTable_tauTable__DQM_obj_floats__rawDeepTau2017v2p1VSmu. https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-01-08-1100+aa6c04/40755/validateJR/all_OldVSNew_TTbar13nanoEDM106Xv1in2017wf1325p81/all_OldVSNew_TTbar13nanoEDM106Xv1in2017wf1325p81c_nanoaodFlatTable_tauTable__DQM_obj_floats__rawDeepTau2017v2p1VSmu_442.png

I can not imagine how the change of this PR could cause that. @cms-sw/reconstruction-l2 @cms-sw/xpog-l2 is there perhaps a known non-reproducibility in DeepTau? (I did not quickly find an open issue about such)

[Dr15Jones]

please test

[mariadalfonso]

@makortel

indeed we have already seen some sign of reproducibility issue
cms-sw/cms-bot#1456 (comment)

[slava77]

One of these is in workflow 1325.81 in nanoaodFlatTable_tauTable__DQM_obj_floats__rawDeepTau2017v2p1VSmu. https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-01-08-1100+aa6c04/40755/validateJR/all_OldVSNew_TTbar13nanoEDM106Xv1in2017wf1325p81/all_OldVSNew_TTbar13nanoEDM106Xv1in2017wf1325p81c_nanoaodFlatTable_tauTable__DQM_obj_floats__rawDeepTau2017v2p1VSmu_442.png

I've seen this before in the tests of cms-sw/cms-bot#1456

it's perhaps time to make an issue

[makortel]

@mariadalfonso @slava77

indeed we have already seen some sign of reproducibility issue
cms-sw/cms-bot#1456 (comment)

Thanks, I had a vague recollection of something like that but was not able to find anything.

it's perhaps time to make an issue

Done in #32628.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa6c04/12066/summary.html
COMMIT: dff0421
CMSSW: CMSSW_11_3_X_2021-01-10-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2716944
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1