Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop type spec in RecoLocalTracker #32625

Merged
merged 2 commits into from Jan 15, 2021
Merged

Conversation

jeongeun
Copy link
Contributor

PR description:

Update the safer syntax for existing parameter :

  • drop type specifications where the original parameter exists.
  • move all parameter inside the clone
    Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
    (The previous PR for RecoLocalTracker is PR#30147. )

In this PR, a total of 2 files changed.
RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiStripZeroSuppression

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32625/20680

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoLocalTracker/Phase2TrackerRecHits
RecoLocalTracker/SiStripZeroSuppression

@perrotta, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@mtosi, @echabert, @yduhm, @GiacomoSguazzoni, @gbenelli, @makortel, @felicepantaleo, @pieterdavid, @robervalwalsh, @JanFSchulte, @rovere, @VinInn, @gpetruc, @alesaggio, @mmusich, @threus, @ebrondol this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

phase2StripCPEGeometricESProducer.ComponentType = 'Phase2StripCPEGeometric'
phase2StripCPEGeometricESProducer.parameters = cms.PSet()
phase2StripCPEGeometricESProducer = phase2StripCPEESProducer.clone(
#ComponentName = 'Phase2StripCPEGeometric',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to keep ComponentName as a comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, there is not such a ComponentName parameter in the phase2StripCPEESProducer config: I think it is better if that commmented out line is simply removed

@srimanob
Copy link
Contributor

Please test

@mmusich
Copy link
Contributor

mmusich commented Jan 10, 2021

@jeongeun
RecoCaloTracker is not an existent subsystem.
I gather you actually mean RecoLocalTracker please update the PR title.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f70b7/12044/summary.html
COMMIT: cb5c808
CMSSW: CMSSW_11_3_X_2021-01-09-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716932
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jeongeun jeongeun changed the title drop type spec in RecoCaloTracker drop type spec in RecoLocalTracker Jan 13, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32625/20714

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32625 was updated. @perrotta, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f70b7/12258/summary.html
COMMIT: b19d029
CMSSW: CMSSW_11_3_X_2021-01-12-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716944
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical: type spec removed from cloned/modified reco configs, as planned
  • Jenkins tests pass

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 15, 2021

+1

@cmsbuild cmsbuild merged commit 6504998 into cms-sw:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants