Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: fix/improvement of CompositeESSource #32640

Merged
merged 1 commit into from Jan 14, 2021

Conversation

jan-kaspar
Copy link
Contributor

This PR contains fixes and improvements of CTPPSCompositeESSource which is used in the PPS direct simulation. The chages include:

  1. add produce methods for alignment ES data
  2. add missing findingRecord calls for geometry ES data - this bug prevented updating geometry up to now
  3. generate new profile only once per transition - performance optimisation
  4. improved documentation

PR validation:

Two comparison sheets are attached below. Blue = before this PR, red dashed after this PR.

dirsim_cmp.pdf: test of the PPS direct simulation. Most of the differences are compatible with a different order of random-number generation due to the point 3) above. The large difference in the top-right corner is expected. Up to now (blue histogram), the geometry was not updated and stayed in the 2016 pre-TS2 configuration where all RPs in sector 56 were functional and inserted closed to the beam. With this PR (red dashed histogram), the geometry is updated during the simulation, thus also sampling the 2016 post-TS2 period, where one RP in the sector 56 was not functional and not inserted in the LHC beam pipe. This obviously reflects in lower yield of reconstructed protons in that sector.

reco_cmp.pdf: test of Run2 data reco - no change, as expected.

* add findingRecord calls for geometry
* generate new profile only once per transition
* improve documentation
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32640/20697

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/ESProducers

@cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks.
@forthommel, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e84d41/12237/summary.html
COMMIT: 8bdd5b1
CMSSW: CMSSW_11_3_X_2021-01-12-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@yuanchao
Copy link
Contributor

+1

  • matrix work flow tests and unit test all passed
  • static build warnings are not part of the modification

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 14, 2021

+1

@cmsbuild cmsbuild merged commit 99e7f4b into cms-sw:master Jan 14, 2021
@jan-kaspar jan-kaspar deleted the composition_es_source_fix branch August 31, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants