New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: fix/improvement of CompositeESSource #32640
Conversation
* add findingRecord calls for geometry * generate new profile only once per transition * improve documentation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32640/20697
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: CalibPPS/ESProducers @cmsbuild, @pohsun, @yuanchao, @christopheralanwest, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e84d41/12237/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR contains fixes and improvements of CTPPSCompositeESSource which is used in the PPS direct simulation. The chages include:
PR validation:
Two comparison sheets are attached below. Blue = before this PR, red dashed after this PR.
dirsim_cmp.pdf: test of the PPS direct simulation. Most of the differences are compatible with a different order of random-number generation due to the point 3) above. The large difference in the top-right corner is expected. Up to now (blue histogram), the geometry was not updated and stayed in the 2016 pre-TS2 configuration where all RPs in sector 56 were functional and inserted closed to the beam. With this PR (red dashed histogram), the geometry is updated during the simulation, thus also sampling the 2016 post-TS2 period, where one RP in the sector 56 was not functional and not inserted in the LHC beam pipe. This obviously reflects in lower yield of reconstructed protons in that sector.
reco_cmp.pdf: test of Run2 data reco - no change, as expected.