New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETL v5 (D73) units of measurement moved to constant section #32645
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32645/20701
|
A new Pull Request was created by @martatornago (martatornago) for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
the running tests cannot show any effect of this PR, but the standalone checks show that the D73 geometry description is unchanged, while addressing the style comments by @cvuosalo |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a771fb/12238/summary.html Comparison SummarySummary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
All the units of measurement have been moved to the constant section.
Numeric values previously hard coded have been associated to new constants, which have been added to the constant section.
PR validation:
The modules positions have been checked with the dump of the geometry using both testMTDinDDD.py and testMTDinDD4hep.py and compared with the output of the previous xml version, verifying they are identical.
Overlaps have been checked with g4OverlapCheck_cfg.py.
Visual check performed with Fireworks.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist:
@fabiocos FYI