New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy memory barriers #32649
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32649/20705
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: FWCore/Concurrency @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-505eaf/12242/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
FWCore/Utilities/src/InputTag.cc and several unit tests in FWCore/Concurrency include calls to __sync_synchronize() because gcc 4.7 didn't fully support the c++11 memory model. All our current and future compilers support the c++ memory model, so these extra synchronization operations should no longer be necessary.
PR validation:
Unit tests were run repeatedly on slc7_amd64_gcc900 and slc7_aarch64_gcc9.