Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety improvements in DT EventSetup formats #3265

Merged
merged 1 commit into from Apr 14, 2014

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 9, 2014

Two singletons are removed. The content that was in
DTCompactMapPluginHandler was moved into the fullMap
function of DTReadoutMapping. The content that was in
DTConfigHandler was moved into the new class
DTKeyedConfigCache. The two modules that used it now
have that as a data member instead of accessing the
functionality through a singleton. In both cases,
the algorithmic code was simply copied to the new
location with minimal changes.

Note the way DTConfigHandler used KeyList with a const_cast
was a problem and remains a problem. I did not fix that
problem. I just noticed it and copied that code from one
place to another. This will probably need to be fixed
at some point in the future.

Remove an optimization that was not needed from
DTReadOutMapping that was added in a very recent
commit by me. Recently I added the atomicCache_ and
cache_ data members and only the atomicCache_ is
really needed so I removed cache_ to simplify the code.

Removed two lines of code that did nothing and some
functions that were never called by anything.
And I renamed a local variable from theCache to
localCache for clarity.

Two singletons are removed. The content that was in
DTCompactMapPluginHandler was moved into the fullMap
function of DTReadoutMapping. The content that was in
DTConfigHandler was moved into the new class
DTKeyedConfigCache. The two modules that used it now
have that as a data member instead of accessing the
functionality through a singleton. In both cases,
the algorithmic code was simply copied to the new
location with minimal changes.

Note the way DTConfigHandler used KeyList with a const_cast
was a problem and remains a problem. I did not fix that
problem. I just noticed it and copied that code from one
place to another. This will probably need to be fixed
at some point in the future.

Remove an optimization that was not needed from
DTReadOutMapping that was added in a very recent
commit by me. Recently I added the atomicCache_ and
cache_ data members and only the atomicCache_ is
really needed so I removed cache_ to simplify the code.

Removed two lines of code that did nothing and some
functions that were never called by anything.
And I renamed a local variable from theCache to
localCache for clarity.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2014

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_X.

Thread safety improvements in DT EventSetup formats

It involves the following packages:

CondCore/DTPlugins
CondFormats/DTObjects
CondTools/DT
L1TriggerConfig/DTTPGConfigProducers

@apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1
note to self: check this also in boostio

@diguida
Copy link
Contributor

diguida commented Apr 10, 2014

+1

@Dr15Jones
Copy link
Contributor

@mulhearn ping?

@ktf
Copy link
Contributor

ktf commented Apr 14, 2014

Bypassing L1 signature. Complain if not ok.

ktf added a commit that referenced this pull request Apr 14, 2014
Multithreading -- Thread safety improvements in DT EventSetup formats
@ktf ktf merged commit 4cc346f into cms-sw:CMSSW_7_1_X Apr 14, 2014
@mulhearn
Copy link
Contributor

Sorry, I missed ping, lecture all day on Mondays…

@wddgit wddgit deleted the dtStaticAnalyzerReports branch May 8, 2014 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants