Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finecalo patches v1 (rebased) #32673

Merged

Conversation

kpedro88
Copy link
Contributor

PR description:

Supersedes #32083: rebased and with some minor adjustments based on #32083 (comment).

PR validation:

Ran SIM with and without --procModifiers fineCalo; observed expected additional content in output file when fineCalo enabled.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32673/20764

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/ProcessModifiers
SimCalorimetry/EcalElectronicsEmulation
SimDataFormats/CaloHit
SimDataFormats/Track
SimG4CMS/Calo
SimG4Core/Application
SimG4Core/Notification

@civanch, @silviodonato, @mdhildreth, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@lecriste, @makortel, @rchatter, @JanFSchulte, @rovere, @argiro, @Martin-Grunewald, @apsallid, @thomreis, @ebrondol, @mtosi, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01e94b/12307/summary.html
COMMIT: 708f9ee
CMSSW: CMSSW_11_3_X_2021-01-15-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2861 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716961
  • DQMHistoTests: Total failures: 9455
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2707484
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@civanch
Copy link
Contributor

civanch commented Jan 16, 2021

@kpedro88 , @cvuosalo , in this PR tests all differences are only in DD4Hep WF 11624.911

@kpedro88
Copy link
Contributor Author

@civanch @cvuosalo I also just saw this in the latest round of tests for #32576. It's definitely not related to that PR, so I doubt it's related to this one either.

@civanch
Copy link
Contributor

civanch commented Jan 16, 2021

Let us see simple PRs (which are just under testing) if DD4Hep regression fails systematically or randomly.

@civanch
Copy link
Contributor

civanch commented Jan 16, 2021

+1

I have signed this PR, because likely only DD4Hep WF show problems, which are not related to this PR.

@kpedro88
Copy link
Contributor Author

@silviodonato @qliphy please take a look

@silviodonato
Copy link
Contributor

enable profiling

@silviodonato
Copy link
Contributor

please test

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01e94b/12334/summary.html
COMMIT: 708f9ee
CMSSW: CMSSW_11_3_X_2021-01-18-1100/slc7_amd64_gcc900
Additional Tests: PROFILING

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716961
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716926
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants