New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching MCSmartSingleParticleFilter to use an input tag (11.1.x) #32679
Switching MCSmartSingleParticleFilter to use an input tag (11.1.x) #32679
Conversation
type bug-fix |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X. It involves the following packages: GeneratorInterface/GenFilters @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport #32491 |
urgent |
please test |
@silviodonato @qliphy please consider this PR for CMSSW_11_1_7 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45050d/12347/summary.html Comparison SummarySummary:
|
+generators |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates the
MCSmartSingleParticleFilter
to use anedm::InputTag
rather than a string to specify its input.This allows to use an instance label different than
"unsmeared"
.PR validation:
See #32491.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #32491.