Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching MCSmartSingleParticleFilter to use an input tag (11.1.x) #32679

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 19, 2021

PR description:

This PR updates the MCSmartSingleParticleFilter to use an edm::InputTag rather than a string to specify its input.
This allows to use an instance label different than "unsmeared".

PR validation:

See #32491.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #32491.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jan 19, 2021
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 19, 2021

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 19, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 19, 2021

backport #32491

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 19, 2021

urgent

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 19, 2021

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 19, 2021

@silviodonato @qliphy please consider this PR for CMSSW_11_1_7

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45050d/12347/summary.html
COMMIT: d27b823
CMSSW: CMSSW_11_1_X_2021-01-17-0000/slc7_amd64_gcc820

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784776
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@agrohsje
Copy link

+generators

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 19, 2021

+1

@cmsbuild cmsbuild merged commit bbf3d5e into cms-sw:CMSSW_11_1_X Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants