New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New HGCal silicon module rotation class #32684
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32684/20792
|
A new Pull Request was created by @snwebb (Samuel Webb) for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32684/20820
|
Pull request #32684 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please check and sign again. |
Thanks for the review - I have modified the class to add the option for 60 degree module rotation, which is needed for the CE-E part of the HGCal. I have tried to tidy the code and symmetrise the functions for 60º and 120º. Also tagging @bsunanda in case of interest. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32684/20890
|
Pull request #32684 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
Test errors are not related to this PR. |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
Add a new class in
Geometry/HGCalCommonData/
which transforms the(u,v)
coordinates of a module in "sector 0" (i.e. 0º-120º) to the correct coordinates in sectors 1 or 2. The reverse function is also provided.This is a base class intended for use in derived classes, and as such does not modify any existing code or output, at present.
This PR is made in conjunction with @jbsauvan
PR validation:
Standard tests have been run successfully. No changes to output expected.