Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(11.1.X) New producers and filters for the Phase 2 Muon HLT #32700

Merged
merged 2 commits into from Jan 21, 2021

Conversation

khaosmos93
Copy link
Contributor

PR description:

This PR adds the following modules (backport of #32699):

  • a new L2 muon seed generator from L1TkMuon
  • a new L3 muon filter with L1TkMuon
  • a new dR filter for MuonRef of L1TkMuon

N.B. To compile it, #32681 should be merged prior to this PR

PR validation:

matrix tests (after merging #32681)

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #32699

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2021

A new Pull Request was created by @khaosmos93 (Minseok Oh) for CMSSW_11_1_X.

It involves the following packages:

HLTrigger/HLTfilters
HLTrigger/Muon
RecoMuon/L2MuonSeedGenerator

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @Fedespring, @Martin-Grunewald, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jan 20, 2021

urgent

@fwyzard
Copy link
Contributor

fwyzard commented Jan 20, 2021

backport #32699

@fwyzard
Copy link
Contributor

fwyzard commented Jan 20, 2021

please test with #32681

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64795a/12399/summary.html
COMMIT: 146eeeb
CMSSW: CMSSW_11_1_X_2021-01-19-2300/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32700/12399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2784828
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784777
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 31 edm output root files, 36 DQM output files

@fwyzard
Copy link
Contributor

fwyzard commented Jan 21, 2021

See the review comments in #32699.

As it would really be helpful to have thins in CMSSW_11_1_7 ASAP, I would prefer to merge it as is, and address the review comments in the next days.

@fwyzard
Copy link
Contributor

fwyzard commented Jan 21, 2021

+hlt

@silviodonato
Copy link
Contributor

Given that #32700 is needed for the upcoming re-HLT, I agree that it is better to merge the PR as it is in order to have the new modules in 11_1_7 instead of merging the PR manually.

@silviodonato
Copy link
Contributor

merge
@khaosmos93 please prepare a follow-up pull request with the implementation of the pending comments (#32699)

@cmsbuild cmsbuild merged commit 5936088 into cms-sw:CMSSW_11_1_X Jan 21, 2021
cmsbuild added a commit that referenced this pull request Jan 27, 2021
(11.1.X) Follow-up of #32700 (Phase 2 Muon HLT)
@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants